[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH V7 03/14] block: return bool for bdrv_can_snapshot()
From: |
Wenchao Xia |
Subject: |
[Qemu-devel] [PATCH V7 03/14] block: return bool for bdrv_can_snapshot() |
Date: |
Tue, 26 Feb 2013 18:40:17 +0800 |
This function should return bool instead of int, just as
bdrv_can_read_snapshot().
Signed-off-by: Wenchao Xia <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
---
block.c | 8 ++++----
include/block/block.h | 2 +-
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/block.c b/block.c
index 19c2d7b..0ed8190 100644
--- a/block.c
+++ b/block.c
@@ -3077,21 +3077,21 @@ bool bdrv_can_read_snapshot(BlockDriverState *bs)
}
/* return whether internal snapshot can be write on @bs */
-int bdrv_can_snapshot(BlockDriverState *bs)
+bool bdrv_can_snapshot(BlockDriverState *bs)
{
BlockDriver *drv = bs->drv;
if (!drv || !bdrv_is_inserted(bs) || bdrv_is_read_only(bs)) {
- return 0;
+ return false;
}
if (!drv->bdrv_snapshot_create) {
if (bs->file != NULL) {
return bdrv_can_snapshot(bs->file);
}
- return 0;
+ return false;
}
- return 1;
+ return true;
}
int bdrv_is_snapshot(BlockDriverState *bs)
diff --git a/include/block/block.h b/include/block/block.h
index 4c48052..2dabb87 100644
--- a/include/block/block.h
+++ b/include/block/block.h
@@ -322,7 +322,7 @@ void bdrv_get_full_backing_filename(BlockDriverState *bs,
BlockInfo *bdrv_query_info(BlockDriverState *s);
BlockStats *bdrv_query_stats(const BlockDriverState *bs);
bool bdrv_can_read_snapshot(BlockDriverState *bs);
-int bdrv_can_snapshot(BlockDriverState *bs);
+bool bdrv_can_snapshot(BlockDriverState *bs);
int bdrv_is_snapshot(BlockDriverState *bs);
BlockDriverState *bdrv_snapshots(void);
int bdrv_snapshot_create(BlockDriverState *bs,
--
1.7.1
- [Qemu-devel] [PATCH V7 02/14] block: add bdrv_can_read_snapshot() function, (continued)
[Qemu-devel] [PATCH V7 03/14] block: return bool for bdrv_can_snapshot(),
Wenchao Xia <=
[Qemu-devel] [PATCH V7 05/14] block: add snapshot info query function bdrv_query_snapshot_infolist(), Wenchao Xia, 2013/02/26
Re: [Qemu-devel] [PATCH V7 05/14] block: add snapshot info query function bdrv_query_snapshot_infolist(), Stefan Hajnoczi, 2013/02/28
[Qemu-devel] [PATCH V7 06/14] block: add image info query function bdrv_query_image_info(), Wenchao Xia, 2013/02/26