[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 1/3] arm/translate.c: Fix adc_CC/sbc_CC imple
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PATCH v3 1/3] arm/translate.c: Fix adc_CC/sbc_CC implementation |
|
Date: |
Mon, 25 Feb 2013 19:47:47 +0000 |
On 25 February 2013 19:41, Richard Henderson <address@hidden> wrote:
> From: Peter Crosthwaite <address@hidden>
>
> commits 49b4c31efcce45ab714f286f14fa5d5173f9069d and
> 2de68a4900ef6eb67380b0c128abfe1976bc66e8 reworked the implementation of adc_CC
> and sub_CC. The new implementations (on the TCG_TARGET_HAS_add2_i32 code path)
> are incorrect. The new logic is:
>
> CF:NF = 0:A +/- 0:CF
> CF:NF = CF:A +/- 0:B
>
> The lower 32 bits of the intermediate result stored in NF needs to be passes
> into the second addition in place of A (s/CF:A/CF:NF):
>
> CF:NF = 0:A +/- 0:CF
> CF:NF = CF:NF +/- 0:B
>
> This patch fixes the issue.
>
> Cc: Peter Maydell <address@hidden>
> Signed-off-by: Peter Crosthwaite <address@hidden>
> Signed-off-by: Richard Henderson <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
-- PMM
- [Qemu-devel] [PATCH v3 0/3] Fix two carry problems in add2 patchset, Richard Henderson, 2013/02/25
- [Qemu-devel] [PATCH v3 1/3] arm/translate.c: Fix adc_CC/sbc_CC implementation, Richard Henderson, 2013/02/25
- Re: [Qemu-devel] [PATCH v3 1/3] arm/translate.c: Fix adc_CC/sbc_CC implementation,
Peter Maydell <=
- [Qemu-devel] [PATCH v3 2/3] target-arm: Fix sbc_CC carry, Richard Henderson, 2013/02/25
- [Qemu-devel] [PATCH v3 3/3] target-ppc: Fix SUBFE carry, Richard Henderson, 2013/02/25
- Re: [Qemu-devel] [PATCH v3 0/3] Fix two carry problems in add2 patchset, Peter Maydell, 2013/02/25
- Re: [Qemu-devel] [PATCH v3 0/3] Fix two carry problems in add2 patchset, Anthony Liguori, 2013/02/26