[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] arm/translate.c: Fix adc_CC/sbc_CC implementati
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH] arm/translate.c: Fix adc_CC/sbc_CC implementation |
Date: |
Mon, 25 Feb 2013 18:24:02 +0000 |
On 25 February 2013 17:15, Laurent Desnogues
<address@hidden> wrote:
> I'm afraid this fix is not enough
I've confirmed with my risu test tool that sbcs/adcs are indeed
broken even with this patch applied. Patterns used:
ADC_imm A1 cond:4 0010101 s:1 rn:4 rd:4 imm:12
ADC_reg A1 cond:4 0000101 s:1 rn:4 rd:4 imm:5 type:2 0 rm:4
ADC_rsr A1 cond:4 0000101 s:1 rn:4 rd:4 rs:4 0 type:2 1 rm:4
SBC_imm A1 cond:4 0010110 s:1 rn:4 rd:4 imm:12
SBC_reg A1 cond:4 0000110 s:1 rn:4 rd:4 imm:5 type:2 0 rm:4
SBC_rsr A1 cond:4 0000110 s:1 rn:4 rd:4 rs:4 0 type:2 1 rm:4
I really must get round to implementing the record-n-replay
functionality so you can run this kind of test without ARM
hardware to hand.
-- PMM