[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 02/15] target-ppc: Move PPC_DUMP_CPU to trans
From: |
Alexander Graf |
Subject: |
Re: [Qemu-devel] [PATCH v2 02/15] target-ppc: Move PPC_DUMP_CPU to translate.c |
Date: |
Mon, 25 Feb 2013 14:48:19 +0100 |
On 25.02.2013, at 14:02, Andreas Färber wrote:
> Am 25.02.2013 13:49, schrieb Alexander Graf:
>>
>> On 21.02.2013, at 05:24, Andreas Färber wrote:
>>
>>> There's an opcode handler field dependent on PPC_DUMP_CPU without which
>>> the build fails.
>>>
>>> Signed-off-by: Andreas Färber <address@hidden>
>>> ---
>>> target-ppc/translate.c | 1 +
>>> target-ppc/translate_init.c | 1 -
>>> 2 Dateien geändert, 1 Zeile hinzugefügt(+), 1 Zeile entfernt(-)
>>>
>>> diff --git a/target-ppc/translate.c b/target-ppc/translate.c
>>> index 2ac5794..2e74e45 100644
>>> --- a/target-ppc/translate.c
>>> +++ b/target-ppc/translate.c
>>> @@ -33,6 +33,7 @@
>>>
>>> /* Include definitions for instructions classes and implementations flags */
>>> //#define PPC_DEBUG_DISAS
>>> +#undef PPC_DUMP_CPU
>>
>> #undef?
>
> // is not permitted. :)
> Alternative would be /* #define ... */
>
> Just edit the line to your liking. :)
The current coding style for debug defines is // #define DEBUG_FOO. It don't
think it makes sense to deviate from that notion unless we do it consistently.
And to do that, we need to consistentify the handling first which your patches
do.
So IMHO I'd rather like to see a patch changing the style to whatever people
prefer after this set is through.
Alex
- Re: [Qemu-devel] [PATCH v2 12/15] target-ppc: Refactor debug output macros, (continued)
- [Qemu-devel] [PATCH v2 05/15] target-cris/mmu.c: Update Coding Style of cris_mmu_translate_page(), Andreas Färber, 2013/02/20
- [Qemu-devel] [PATCH v2 11/15] target-openrisc: Refactor debug output macros, Andreas Färber, 2013/02/20
- [Qemu-devel] [PATCH v2 04/15] target-cris/helper.c: Update Coding Style, Andreas Färber, 2013/02/20
- [Qemu-devel] [PATCH v2 14/15] target-sparc: Refactor debug output macros, Andreas Färber, 2013/02/20
- [Qemu-devel] [PATCH v2 15/15] target-unicore32: Refactor debug output macros, Andreas Färber, 2013/02/20
- [Qemu-devel] [PATCH v2 02/15] target-ppc: Move PPC_DUMP_CPU to translate.c, Andreas Färber, 2013/02/20
[Qemu-devel] [PATCH v2 13/15] target-s390x: Refactor debug output macros, Andreas Färber, 2013/02/20
Re: [Qemu-devel] [PATCH v2 00/15] Debug output revamp, Richard Henderson, 2013/02/21