[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 4/6] introduce new vma archive format
From: |
Dietmar Maurer |
Subject: |
Re: [Qemu-devel] [PATCH v5 4/6] introduce new vma archive format |
Date: |
Mon, 25 Feb 2013 06:18:54 +0000 |
> > + if (full_read(vmar->fd, vmar->head_data, sizeof(VmaHeader)) !=
> > + sizeof(VmaHeader)) {
> > + error_setg(errp, "can't read vma header - %s",
> > + errno ? strerror(errno) : "got EOF");
>
> You're not the first user, but strerror() isn't thread-safe. strerror_r is
> not
> necessarily portable (glibc vs. POSIX), and strerror_l isn't yet widely
> implemented. Should qemu be providing a better interface
> qemu_strerror() that guarantees thread-safety when converting errno to a
> string?
I thought I can use g_strerror?
- Re: [Qemu-devel] [PATCH v5 3/6] add backup related monitor commands, (continued)
- [Qemu-devel] [PATCH v5 1/6] add documenation for new backup framework, Dietmar Maurer, 2013/02/21
- [Qemu-devel] [PATCH v5 2/6] add basic backup support to block driver, Dietmar Maurer, 2013/02/21
- [Qemu-devel] [PATCH v5 5/6] add regression tests for backup, Dietmar Maurer, 2013/02/21
- [Qemu-devel] [PATCH v5 6/6] add vm state to backups, Dietmar Maurer, 2013/02/21
- [Qemu-devel] [PATCH v5 4/6] introduce new vma archive format, Dietmar Maurer, 2013/02/21
Re: [Qemu-devel] [PATCH v5 4/6] introduce new vma archive format, Markus Armbruster, 2013/02/27
Re: [Qemu-devel] [PATCH v5 0/6] Efficient VM backup for qemu, Markus Armbruster, 2013/02/22