[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 08/10] target-i386: cleanup 'foo' feature handling'
From: |
Igor Mammedov |
Subject: |
[Qemu-devel] [PATCH 08/10] target-i386: cleanup 'foo' feature handling' |
Date: |
Mon, 25 Feb 2013 02:03:07 +0100 |
features check, enforce, hv_relaxed and hv_vapic are treated as boolean set to
'on'
when passed from command line, so it's not neccessary to handle each of them
separetly. Collapse them to one catch-all branch which will treat
any feature in format 'foo' as boolean set to 'on'.
PS:
Any unknown feature will be rejected by CPU property setter so there is no
need to check for unknown feature in cpu_x86_parse_featurestr(), therefore
it's replaced by above mentioned catch-all handler.
Signed-off-by: Igor Mammedov <address@hidden>
Reviewed-by: Eduardo Habkost <address@hidden>
---
v2:
* use feat2prop() to perform name convertion for hv_vapic and hv_relaxed
---
target-i386/cpu.c | 13 ++-----------
1 files changed, 2 insertions(+), 11 deletions(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 6826224..1073bdc 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -1485,18 +1485,9 @@ static void cpu_x86_parse_featurestr(X86CPU *cpu, char
*features, Error **errp)
error_setg(errp, "unrecognized feature %s", featurestr);
goto out;
}
- } else if (!strcmp(featurestr, "check")) {
- object_property_parse(OBJECT(cpu), "on", featurestr, errp);
- } else if (!strcmp(featurestr, "enforce")) {
- object_property_parse(OBJECT(cpu), "on", featurestr, errp);
- } else if (!strcmp(featurestr, "hv_relaxed")) {
- object_property_parse(OBJECT(cpu), "on", "hv-relaxed", errp);
- } else if (!strcmp(featurestr, "hv_vapic")) {
- object_property_parse(OBJECT(cpu), "on", "hv-vapic", errp);
} else {
- error_setg(errp, "feature string `%s' not in format (+feature|"
- "-feature|feature=xyz)", featurestr);
- goto out;
+ feat2prop(featurestr);
+ object_property_parse(OBJECT(cpu), "on", featurestr, errp);
}
if (error_is_set(errp)) {
goto out;
--
1.7.1
- [Qemu-devel] [PATCH 01/10] qdev: add qdev property for bool type, (continued)
[Qemu-devel] [PATCH 02/10] target-i386: cpu: convert existing dynamic properties into static properties, Igor Mammedov, 2013/02/24
[Qemu-devel] [PATCH 07/10] target-i386: convert 'check' and 'enforce' to static properties, Igor Mammedov, 2013/02/24
[Qemu-devel] [PATCH 05/10] target-i386: convert 'hv_relaxed' to static property, Igor Mammedov, 2013/02/24
[Qemu-devel] [PATCH 08/10] target-i386: cleanup 'foo' feature handling',
Igor Mammedov <=
[Qemu-devel] [PATCH 04/10] target-i386: convert 'hv_spinlocks' to static property, Igor Mammedov, 2013/02/24
[Qemu-devel] [PATCH 06/10] target-i386: convert 'hv_vapic' to static property, Igor Mammedov, 2013/02/24
[Qemu-devel] [PATCH 09/10] target-i386: cleanup 'foo=val' feature handling, Igor Mammedov, 2013/02/24
[Qemu-devel] [PATCH 10/10] target-i386: set [+-]feature using static properties, Igor Mammedov, 2013/02/24