|
From: | Juan Quintela |
Subject: | Re: [Qemu-devel] [PATCH 11/41] migration: simplify error handling |
Date: | Thu, 21 Feb 2013 18:34:25 +0100 |
User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) |
Paolo Bonzini <address@hidden> wrote: > Always use qemu_file_get_error to detect errors, since that is how > QEMUFile itself drops I/O after an error occurs. There is no need > to propagate and check return values all the time. > > Also remove the "complete" member, since we know that it is set (via > migrate_fd_cleanup) only when the state changes. > > Signed-off-by: Paolo Bonzini <address@hidden> This move buffered_flush() to inside the iothread lock. At least the commit message needs to be changed. Looking at the rest of the series before thinking if that is the right approach. Later, Juan.
[Prev in Thread] | Current Thread | [Next in Thread] |