qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/3] Revert "make_device_config.sh: Fix target p


From: Andreas Färber
Subject: Re: [Qemu-devel] [PATCH 1/3] Revert "make_device_config.sh: Fix target path in generated dependency file"
Date: Thu, 21 Feb 2013 16:33:42 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130105 Thunderbird/17.0.2

Am 21.02.2013 16:30, schrieb Peter Maydell:
> On 21 February 2013 15:26, Andreas Färber <address@hidden> wrote:
>> This reverts commit 23bf49b5eca716aaad073f2b47613434e1515cb5.
>>
>> While *-softmmu/config-devices.mak.d is included through *.d pattern via
>> Makefile.target, the make_devices_config.sh call these dependencies are
>> for is in ./Makefile. Therefore revert to original behavior.
> 
> This commit message is wrong, isn't it? *-softmmu/config-devices.mak.d
> is included from Makefile, not Makefile.target:
> 
> SUBDIR_DEVICES_MAK_DEP=$(patsubst %, %/config-devices.mak.d, $(TARGET_DIRS))
> # and then later:
> -include $(SUBDIR_DEVICES_MAK_DEP)

That's exactly what I have just been discussing with Paolo: It is in
fact included from both, both back then and today! -> 2/3

I can surely reword the commit message though to make that more clear.
Point is my reverted commit message was not wrong, just half-wrong. :)

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg



reply via email to

[Prev in Thread] Current Thread [Next in Thread]