[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 27/41] migration: remove useless qemu_file_get_e
From: |
Orit Wasserman |
Subject: |
Re: [Qemu-devel] [PATCH 27/41] migration: remove useless qemu_file_get_error check |
Date: |
Thu, 21 Feb 2013 09:33:56 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 |
On 02/15/2013 07:46 PM, Paolo Bonzini wrote:
> migration_put_buffer is never called if there has been an error.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> migration.c | 6 ------
> 1 files changed, 0 insertions(+), 6 deletions(-)
>
> diff --git a/migration.c b/migration.c
> index 63ecab5..3de7cbf 100644
> --- a/migration.c
> +++ b/migration.c
> @@ -512,12 +512,6 @@ static int migration_put_buffer(void *opaque, const
> uint8_t *buf,
>
> DPRINTF("putting %d bytes at %" PRId64 "\n", size, pos);
>
> - ret = qemu_file_get_error(s->file);
> - if (ret) {
> - DPRINTF("flush when error, bailing: %s\n", strerror(-error));
> - return ret;
> - }
> -
> if (size <= 0) {
> return size;
> }
>
Reviewed-by: Orit Wasserman <address@hidden>
- Re: [Qemu-devel] [PATCH 23/41] Rename buffered_ to migration_, (continued)
- [Qemu-devel] [PATCH 22/41] migration: yay, buffering is gone, Paolo Bonzini, 2013/02/15
- [Qemu-devel] [PATCH 27/41] migration: remove useless qemu_file_get_error check, Paolo Bonzini, 2013/02/15
- [Qemu-devel] [PATCH 25/41] migration: eliminate last_round, Paolo Bonzini, 2013/02/15
- [Qemu-devel] [PATCH 26/41] migration: detect error before sleeping, Paolo Bonzini, 2013/02/15
- [Qemu-devel] [PATCH 30/41] qemu-file: fsync a writable stdio QEMUFile, Paolo Bonzini, 2013/02/15