Re: [Qemu-devel] [PATCH 2/2] qxl: change rom size to 8192

[Gerd Hoffmann]

  Hi,

>> I took a stab at this, unfortunately the situation isn't that simple. qxl
>> rom_size is actually dependent on the spice version we build against:
>>
>> stock qemu 1.2 built on F17 against spice-0.10.1:
>> sizeof(QXLRom)=72 rom_size=8192
>>
>> stock qemu 1.2 built on F18 against spice-0.12.2:
>> sizeof(QXLRom)=1160 rom_size=16834
>>
>> Maybe a more complex solution like Alon proposed up thread is needed.

> For reference, here's the patch I'm carrying in Fedora. It likely isn't
> suitable for upstream given what I mentioned above, but is good enough
> to handle rom sizes of Fedora packages.

Patch looks fine for fedora, but, yes, it isn't a generic solution.

I'm not sure there is one in the first place, the spice version
dependency is nasty.

cheers,
  Gerd