[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/4] piix_pci: Implement reset for i440FX PAM co
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH 4/4] piix_pci: Implement reset for i440FX PAM configuration |
Date: |
Thu, 21 Feb 2013 00:40:42 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130105 Thunderbird/17.0.2 |
Am 21.02.2013 00:34, schrieb David Woodhouse:
> On Thu, 2013-02-21 at 00:31 +0100, Andreas Färber wrote:
>>
>>
>> Reviewed-by: Andreas Färber <address@hidden>
>>
>> A minor suggestion since you seem to be preparing a v2 would be to do
>> I440FX_PCI_DEVICE(ds), but I don't see dev becoming unused anytime
>> soon, therefore moot.
>
> Well it's only used because you told me *not* to use d->dev :)
>
> But OK. The tree at git.infradead.org/users/dwmw2/qemu.git now has that
> change, Laszlo's Reviewed-by: and Tested-by: on all four patches, and
> yours on three of the four. Thanks.
You're welcome. On your master branch you may add my Rb on the 4th too.
Just not mentioning it here to avoid confusing patches tool.
Thank you,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- Re: [Qemu-devel] [PATCH 3/4] piix_pci: Fix C99 comments, (continued)
- [Qemu-devel] [PATCH 4/4] piix_pci: Implement reset for i440FX PAM configuration, David Woodhouse, 2013/02/20
- Re: [Qemu-devel] [PATCH 4/4] piix_pci: Implement reset for i440FX PAM configuration, Laszlo Ersek, 2013/02/20
- Re: [Qemu-devel] [PATCH 4/4] piix_pci: Implement reset for i440FX PAM configuration, Andreas Färber, 2013/02/20
- Re: [Qemu-devel] [PATCH 4/4] piix_pci: Implement reset for i440FX PAM configuration, David Woodhouse, 2013/02/20
- Re: [Qemu-devel] [PATCH 4/4] piix_pci: Implement reset for i440FX PAM configuration,
Andreas Färber <=
- Re: [Qemu-devel] [PATCH 4/4] piix_pci: Implement reset for i440FX PAM configuration, Paolo Bonzini, 2013/02/21
- Re: [Qemu-devel] [PATCH 4/4] piix_pci: Implement reset for i440FX PAM configuration, David Woodhouse, 2013/02/21
- Re: [Qemu-devel] [PATCH 4/4] piix_pci: Implement reset for i440FX PAM configuration, David Woodhouse, 2013/02/21
- Re: [Qemu-devel] [PATCH 4/4] piix_pci: Implement reset for i440FX PAM configuration, Laszlo Ersek, 2013/02/21
Re: [Qemu-devel] [PATCH 1/4] piix_pci: Clean up i440FX object handling, Andreas Färber, 2013/02/20