[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] Replace all setjmp()/longjmp() with sigsetjm
|
From: |
Laszlo Ersek |
|
Subject: |
Re: [Qemu-devel] [PATCH v2] Replace all setjmp()/longjmp() with sigsetjmp()/siglongjmp() |
|
Date: |
Wed, 20 Feb 2013 16:46:36 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130108 Thunderbird/10.0.12 |
On 02/20/13 16:21, Peter Maydell wrote:
> +#define sigjmp_buf jmp_buf
> +#define sigsetjmp(env, savemask) setjmp(env)
> +#define siglongjmp(env, val) longjmp(env, val)
Apologies for not really reviewing v1; do you think it would be useful
to add parens around "env" and "val" in the siglongjmp() replacement text?
Also, maybe it would be cleaner to replace these windows-oriented
#defines with a commonly used, new set of macros that would expand to
sig* and ", 0" on non-windows, and to the current text on windows.
That said,
Reviewed-by: Laszlo Ersek <address@hidden>
Cheers
Laszlo