[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] win32: do not set CPU affinity
From: |
Laszlo Ersek |
Subject: |
Re: [Qemu-devel] [PATCH 1/2] win32: do not set CPU affinity |
Date: |
Wed, 20 Feb 2013 15:43:54 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130108 Thunderbird/10.0.12 |
On 02/20/13 14:43, Paolo Bonzini wrote:
> QEMU system emulation has been thread-safe for a long time, and
> setting the CPU affinity is hurting performance badly. Remove
> the bogus code.
>
> Jacob Kroon reports that the time to boot his VxWorks image goes from
> "3 minutes passed and I still haven't made it that far" to ~140s.
>
> Cc: address@hidden
> Tested-by: Jacob Kroon <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> Jacob, this is "patch 3" you tested.
>
> os-win32.c | 18 -------------------
> 1 file changed, 18 deletions(-)
>
> diff --git a/os-win32.c b/os-win32.c
> index 9673a81..3d43604 100644
> --- a/os-win32.c
> +++ b/os-win32.c
> @@ -69,25 +69,7 @@ static BOOL WINAPI qemu_ctrl_handler(DWORD type)
>
> void os_setup_early_signal_handling(void)
> {
> - /* Note: cpu_interrupt() is currently not SMP safe, so we force
> - QEMU to run on a single CPU */
> - HANDLE h;
> - DWORD_PTR mask, smask;
> - int i;
> -
> SetConsoleCtrlHandler(qemu_ctrl_handler, TRUE);
> -
> - h = GetCurrentProcess();
> - if (GetProcessAffinityMask(h, &mask, &smask)) {
> - for(i = 0; i < 32; i++) {
> - if (mask & (1 << i))
> - break;
> - }
> - if (i != 32) {
> - mask = 1 << i;
> - SetProcessAffinityMask(h, mask);
> - }
> - }
> }
>
> /* Look for support files in the same directory as the executable. */
Reviewed-by: Laszlo Ersek <address@hidden>
(The list server is slow, I can't see 2/2 yet.)
Laszlo
- [Qemu-devel] [PATCH 0/2] Win32 fixes, Paolo Bonzini, 2013/02/20
- Re: [Qemu-devel] [PATCH 1/2] win32: do not set CPU affinity, Roy Tam, 2013/02/20
- Re: [Qemu-devel] [PATCH 1/2] win32: do not set CPU affinity, Paolo Bonzini, 2013/02/21
- Re: [Qemu-devel] [PATCH 1/2] win32: do not set CPU affinity, Roy Tam, 2013/02/21
- Re: [Qemu-devel] [PATCH 1/2] win32: do not set CPU affinity, Roy Tam, 2013/02/21
- Re: [Qemu-devel] [PATCH 1/2] win32: do not set CPU affinity, Paolo Bonzini, 2013/02/21
- Re: [Qemu-devel] [PATCH 1/2] win32: do not set CPU affinity, Roy Tam, 2013/02/21