[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] tap: forbid creating multiqueue tap when hub is
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH] tap: forbid creating multiqueue tap when hub is used |
Date: |
Wed, 20 Feb 2013 14:08:08 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Feb 20, 2013 at 05:18:08PM +0800, Jason Wang wrote:
> diff --git a/net/tap.c b/net/tap.c
> index 48c254e..1e14f59 100644
> --- a/net/tap.c
> +++ b/net/tap.c
> @@ -693,6 +693,12 @@ int net_init_tap(const NetClientOptions *opts, const
> char *name,
> queues = tap->has_queues ? tap->queues : 1;
> vhostfdname = tap->has_vhostfd ? tap->vhostfd : NULL;
>
> + if (peer && (tap->has_queues || tap->has_fds || tap->has_vhostfds)) {
> + error_report("This configuration is not compatiable with multiqueue"
> + " tap");
s/compatiable/compatible/
The error message should be specific, for example, "multiqueue tap
cannot be used with QEMU vlans".
A comment would be nice too to remind readers that peer is only set when
QEMU vlans are in use. peer is always NULL for -netdev.
Stefan