[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 6/6] qcow2: drop unnecessary flush in qcow2_update_s
From: |
Stefan Hajnoczi |
Subject: |
[Qemu-devel] [PATCH 6/6] qcow2: drop unnecessary flush in qcow2_update_snapshot_refcount() |
Date: |
Tue, 19 Feb 2013 16:45:06 +0100 |
We already flush when the function completes. There is no need to flush
after every compressed cluster.
Signed-off-by: Stefan Hajnoczi <address@hidden>
---
block/qcow2-refcount.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c
index 12d9065..9eb1aba 100644
--- a/block/qcow2-refcount.c
+++ b/block/qcow2-refcount.c
@@ -780,10 +780,6 @@ int qcow2_update_snapshot_refcount(BlockDriverState *bs,
if (ret < 0) {
goto fail;
}
-
- /* TODO Flushing once for the whole function should
- * be enough */
- bdrv_flush(bs->file);
}
/* compressed clusters are never modified */
refcount = 2;
--
1.8.1.2
- [Qemu-devel] [PATCH 0/6] qcow2: cache flush fixes and performance improvements, Stefan Hajnoczi, 2013/02/19
- [Qemu-devel] [PATCH 1/6] qcow2: flush refcount cache correctly in alloc_refcount_block(), Stefan Hajnoczi, 2013/02/19
- [Qemu-devel] [PATCH 4/6] qcow2: flush in qcow2_update_snapshot_refcount(), Stefan Hajnoczi, 2013/02/19
- [Qemu-devel] [PATCH 2/6] qcow2: flush refcount cache correctly in qcow2_write_snapshots(), Stefan Hajnoczi, 2013/02/19
- [Qemu-devel] [PATCH 5/6] qcow2: drop flush in update_cluster_refcount(), Stefan Hajnoczi, 2013/02/19
- [Qemu-devel] [PATCH 3/6] qcow2: flush caches in qcow2_alloc_bytes(), Stefan Hajnoczi, 2013/02/19
- [Qemu-devel] [PATCH 6/6] qcow2: drop unnecessary flush in qcow2_update_snapshot_refcount(),
Stefan Hajnoczi <=
- Re: [Qemu-devel] [PATCH 0/6] qcow2: cache flush fixes and performance improvements, Eric Blake, 2013/02/19
- Re: [Qemu-devel] [PATCH 0/6] qcow2: cache flush fixes and performance improvements, Kevin Wolf, 2013/02/20