qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH 6/6] qcow2: drop unnecessary flush in qcow2_update_s


From: Stefan Hajnoczi
Subject: [Qemu-devel] [PATCH 6/6] qcow2: drop unnecessary flush in qcow2_update_snapshot_refcount()
Date: Tue, 19 Feb 2013 16:45:06 +0100

We already flush when the function completes.  There is no need to flush
after every compressed cluster.

Signed-off-by: Stefan Hajnoczi <address@hidden>
---
 block/qcow2-refcount.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c
index 12d9065..9eb1aba 100644
--- a/block/qcow2-refcount.c
+++ b/block/qcow2-refcount.c
@@ -780,10 +780,6 @@ int qcow2_update_snapshot_refcount(BlockDriverState *bs,
                             if (ret < 0) {
                                 goto fail;
                             }
-
-                            /* TODO Flushing once for the whole function should
-                             * be enough */
-                            bdrv_flush(bs->file);
                         }
                         /* compressed clusters are never modified */
                         refcount = 2;
-- 
1.8.1.2




reply via email to

[Prev in Thread] Current Thread [Next in Thread]