Re: [Qemu-devel] [RFC PATCH 4/4] block: add vhdx to Makefile.obj for compile

[Kevin Wolf]

On Mon, Feb 18, 2013 at 06:03:32PM -0500, Jeff Cody wrote:
> 
> Signed-off-by: Jeff Cody <address@hidden>
> ---
>  block/Makefile.objs | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/block/Makefile.objs b/block/Makefile.objs
> index c067f38..a819577 100644
> --- a/block/Makefile.objs
> +++ b/block/Makefile.objs
> @@ -2,6 +2,7 @@ block-obj-y += raw.o cow.o qcow.o vdi.o vmdk.o cloop.o dmg.o 
> bochs.o vpc.o vvfat
>  block-obj-y += qcow2.o qcow2-refcount.o qcow2-cluster.o qcow2-snapshot.o 
> qcow2-cache.o
>  block-obj-y += qed.o qed-gencb.o qed-l2-cache.o qed-table.o qed-cluster.o
>  block-obj-y += qed-check.o
> +block-obj-y += vhdx.o
>  block-obj-y += parallels.o blkdebug.o blkverify.o
>  block-obj-$(CONFIG_WIN32) += raw-win32.o win32-aio.o
>  block-obj-$(CONFIG_POSIX) += raw-posix.o

There's no reason for this to be a separate patch. Please merge it with
patch 3.

I think the series may well grow to a point where splitting it into
multiple patches becomes necessary, but even then it should be split
by adding a piece of functionality in each step, not by putting each
file in a separate patch.

Kevin