[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-1.5 0/8] virtio-blk refactoring.
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH for-1.5 0/8] virtio-blk refactoring. |
Date: |
Mon, 18 Feb 2013 14:39:46 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Mon, Feb 18, 2013 at 11:34:25AM +0100, KONRAD Frédéric wrote:
> On 11/02/2013 10:37, address@hidden wrote:
> >From: KONRAD Frederic <address@hidden>
> >
> >This is the next part of virtio-refactoring.
> >
> >I send it now to have it reviewed.
> >
> >Basically it creates virtio-blk device which extends virtio-device.
> >Then a virtio-blk can be connected on a virtio-bus.
> >virtio-blk-pci, virtio-blk-s390x, virtio-blk-ccw are created too, they extend
> >respectively virtio-pci, virtio-s390-device, virtio-ccw-device and have a
> >virtio-blk.
> >
> >It is on top of "virtio: make virtio device's structures public" I posted
> >before, but you can checkout my branch here:
> >
> >git://git.greensocs.com/qemu_virtio.git virtio-blk-v4
> >
> >I made basic tests (with linux guests) on:
> > * qemu-system-i386
> > * qemu-system-s390x
> >
> >I didn't test dataplane as I don't know how it works? Depends on linux AIO?
> >
> >Stefan can you try launching dataplane with my tree?
It works after I apply this small patch:
diff --git a/hw/virtio-blk.h b/hw/virtio-blk.h
index f281ac3..0f964a7 100644
--- a/hw/virtio-blk.h
+++ b/hw/virtio-blk.h
@@ -16,6 +16,7 @@
#include "virtio.h"
#include "hw/block-common.h"
+#include "hw/dataplane/virtio-blk.h"
#define TYPE_VIRTIO_BLK "virtio-blk"
#define VIRTIO_BLK(obj) \
- Re: [Qemu-devel] [PATCH for 1.5] virtio: make virtio device's structures public., (continued)
- [Qemu-devel] [PATCH for-1.5 3/8] virtio-blk-pci: switch to new API., fred . konrad, 2013/02/11
- [Qemu-devel] [PATCH for-1.5 4/8] virtio-blk-s390: switch to the new API., fred . konrad, 2013/02/11
- [Qemu-devel] [PATCH for-1.5 5/8] virtio-blk-ccw switch to new API., fred . konrad, 2013/02/11
- [Qemu-devel] [PATCH for-1.5 6/8] virtio-blk: cleanup: init and exit functions., fred . konrad, 2013/02/11
- [Qemu-devel] [PATCH for-1.5 7/8] virtio-blk: cleanup: QOM cast, fred . konrad, 2013/02/11
- [Qemu-devel] [PATCH for-1.5 8/8] virtio-blk: cleanup: remove qdev field., fred . konrad, 2013/02/11
- Re: [Qemu-devel] [PATCH for-1.5 0/8] virtio-blk refactoring., Cornelia Huck, 2013/02/11
- Re: [Qemu-devel] [PATCH for-1.5 0/8] virtio-blk refactoring., KONRAD Frédéric, 2013/02/18
- Re: [Qemu-devel] [PATCH for-1.5 0/8] virtio-blk refactoring.,
Stefan Hajnoczi <=