Re: [Qemu-devel] [PATCH V2 for-1.5] virtio: make virtio device's structures public.

[KONRAD Frédéric]

On 18/02/2013 09:59, Andreas Färber wrote:
> Am 18.02.2013 09:53, schrieb KONRAD Frédéric:
> > On 18/02/2013 09:47, Andreas Färber wrote:
> > > Am 12.02.2013 18:00, schrieb address@hidden:
> > > > From: KONRAD Frederic <address@hidden>
> > > >
> > > > These structures must be made public to avoid two memory allocations for
> > > > refactored virtio devices.
> > > >
> > > > Changes V2 <- V1:
> > > >       * Move the dataplane include into the header (virtio-blk).
> > > >
> > > > Signed-off-by: KONRAD Frederic <address@hidden>
> > > > ---
> > > >    hw/virtio-balloon.c    | 15 ---------------
> > > >    hw/virtio-balloon.h    | 14 ++++++++++++++
> > > >    hw/virtio-blk.c        | 19 -------------------
> > > >    hw/virtio-blk.h        | 18 ++++++++++++++++++
> > > >    hw/virtio-net.c        | 50
> > > > -------------------------------------------------
> > > >    hw/virtio-net.h        | 51
> > > > ++++++++++++++++++++++++++++++++++++++++++++++++++
> > > >    hw/virtio-rng.c        | 19 -------------------
> > > >    hw/virtio-rng.h        | 19 +++++++++++++++++++
> > > >    hw/virtio-scsi.c       | 15 ---------------
> > > >    hw/virtio-scsi.h       | 16 ++++++++++++++++
> > > >    hw/virtio-serial-bus.c | 41 ----------------------------------------
> > > >    hw/virtio-serial.h     | 41 ++++++++++++++++++++++++++++++++++++++++
> > > >    12 files changed, 159 insertions(+), 159 deletions(-)
> > > [...]
> > > > diff --git a/hw/virtio-scsi.h b/hw/virtio-scsi.h
> > > > index 8d9d15f..613deb5 100644
> > > > --- a/hw/virtio-scsi.h
> > > > +++ b/hw/virtio-scsi.h
> > > > @@ -16,6 +16,7 @@
> > > >      #include "virtio.h"
> > > >    #include "pci/pci.h"
> > > > +#include <hw/scsi.h>
> > > This should be "hw/scsi.h" and change log should not be in commit
> > > message. Otherwise looks okay as a pure movement, not tested.
Note that I copied this line (with <hw/scsi.h>) from virtio-scsi.c.
> > Ok,
> >
> > I thought the change log was allowed as it is a one patch series.
> >
> > Do you think I must remove it?
> For a one-patch series without cover letter the change log should go
> under --- so that it doesn't get committed.
Ok thanks, I'll fix that.

> > I tested it, it was breaking dataplane compilation, that's why I made
> > the second version.
> >
> > As it is a pure movement it don't require heaving testing right?
> Compile-testing should suffice, but I didn't test whether the virtio-net
> multiqueue changes for instance have broken it.
>
> Andreas
It should work, I rebased it on the latest git before sending it.

Thanks,
Fred