Re: [Qemu-devel] [PATCH] Fix conversion between 12 hours and 24 hours modes.

[Antoine Mathys]

On 02/15/2013 12:24 PM, Andreas Färber wrote:
> The expected answer would've been "take guest X and do Y to see Z", or
> better to extend the existing qtest cases to prove something was broken
> before and fixed afterwards and to avoid the same bug being reintroduced
> later.

If we are talking about adding a test case in order to have some guarantee that 
what works after a fix keeps working in the future, that's fine. And I am 
willing to add such tests for the DS1338 implementation (once it is finished).

But demanding a test case that the code passes with the fix but fails without, 
in order to prove that something was broken before, is only reasonable if the 
bug was found through testing in the first place.

It is inappropriate for a bug found in a code review. Not only do you not need 
a test case to prove the bug exists, but reverse-engineering a test-case can be 
a significant undertaking. Paolo tried to do that unsuccessfully in the case of 
bug 1090558 and I had no reason to think I could do better. This does not 
strike me as a very productive use of developer time anyway.

And your suggestion that it is better to leave a known bug unpatched until 
someone can conjure up a test case is ridiculous. I don't see how that attitude 
help users, in the short or long term.

If you don't nuance your position you are only going to discourage much needed 
code reviews. I don't see what good can come of that.