[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [seabios][PATCH 1/2] move all acpi-table related defini
|
From: |
li guang |
|
Subject: |
Re: [Qemu-devel] [seabios][PATCH 1/2] move all acpi-table related definitions to acpi.h |
|
Date: |
Fri, 15 Feb 2013 09:06:26 +0800 |
在 2013-02-06三的 23:15 -0500，Kevin O'Connor写道：
> On Mon, Feb 04, 2013 at 10:27:59AM +0800, liguang wrote:
> > Signed-off-by: liguang <address@hidden>
>
> Thanks. Some comments.
>
> [...]
> > --- a/src/acpi.h
> > +++ b/src/acpi.h
> [...]
> > +#include "acpi-dsdt.hex"
>
> Moving the acpi structure defines to the header is fine, but moving
> the DSDT code into the header is definitely not right.
OK, will remove this include.
>
> -Kevin
>
- Re: [Qemu-devel] [PATCH 5/6] load_linux: report open kernel file & its size error, (continued)
- [Qemu-devel] [PATCH 2/6] pc/numa: refactor bios_init function, liguang, 2013/02/03
- [Qemu-devel] [PATCH 3/6] bitops: change BITS_TO_LONGS, liguang, 2013/02/03
- [Qemu-devel] [PATCH 4/6] pc: format load_linux(), liguang, 2013/02/03
- [Qemu-devel] [seabios][PATCH 2/2] acpi: change numa data format from fw_cfg interface, liguang, 2013/02/03
- [Qemu-devel] [seabios][PATCH 1/2] move all acpi-table related definitions to acpi.h, liguang, 2013/02/03