[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V4 RESEND 09/22] net: multiqueue support
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH V4 RESEND 09/22] net: multiqueue support |
Date: |
Tue, 12 Feb 2013 22:24:35 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130105 Thunderbird/17.0.2 |
Am 01.02.2013 08:39, schrieb Jason Wang:
> diff --git a/net/net.c b/net/net.c
> index 98a1934..9806862 100644
> --- a/net/net.c
> +++ b/net/net.c
[...]
> @@ -271,9 +287,7 @@ static void qemu_cleanup_net_client(NetClientState *nc)
> {
> QTAILQ_REMOVE(&net_clients, nc, next);
>
> - if (nc->info->cleanup) {
> - nc->info->cleanup(nc);
> - }
> + nc->info->cleanup(nc);
> }
This change broke qemu-system-ppc64 -M pseries.
Why was the NULL guard dropped?
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- [Qemu-devel] [PATCH V4 RESEND 15/22] tap: multiqueue support, (continued)
- [Qemu-devel] [PATCH V4 RESEND 15/22] tap: multiqueue support, Jason Wang, 2013/02/01
- [Qemu-devel] [PATCH V4 RESEND 17/22] virtio: introduce virtio_del_queue(), Jason Wang, 2013/02/01
- [Qemu-devel] [PATCH V4 RESEND 21/22] virtio-net: migration support for multiqueue, Jason Wang, 2013/02/01
- [Qemu-devel] [PATCH V4 RESEND 12/22] tap: add Linux multiqueue support, Jason Wang, 2013/02/01
- [Qemu-devel] [PATCH V4 RESEND 22/22] virtio-net: compat multiqueue support, Jason Wang, 2013/02/01
- [Qemu-devel] [PATCH V4 RESEND 09/22] net: multiqueue support, Jason Wang, 2013/02/01
- Re: [Qemu-devel] [PATCH V4 RESEND 00/22] Multiqueue virtio-net, Jason Wang, 2013/02/01
- [Qemu-devel] [PATCH V4 RESEND 20/22] virtio-net: multiqueue support, Jason Wang, 2013/02/01
- [Qemu-devel] [PATCH V4 RESEND 10/22] tap: import linux multiqueue constants, Jason Wang, 2013/02/01
- [Qemu-devel] [PATCH V4 RESEND 11/22] tap: factor out common tap initialization, Jason Wang, 2013/02/01
- Re: [Qemu-devel] [PATCH V4 RESEND 00/22] Multiqueue virtio-net, Anthony Liguori, 2013/02/04