[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH RDMA support v2: 3/6] install new monitor co
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-devel] [RFC PATCH RDMA support v2: 3/6] install new monitor commands and setup RDMA capabilities |
|
Date: |
Tue, 12 Feb 2013 19:53:21 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) |
Eric Blake <address@hidden> writes:
> On 02/11/2013 08:06 PM, Michael R. Hines wrote:
>
> [no need to top-post on a technical list]
>
>> None of the other migration QMP commands use dashes.
>
> Then how do you explain 'query-migrate', 'migrate-set-capabilities',
> 'query-migrate-capabilities', 'migrate-set-cache-size',
> 'query-migrate-cache-size'? I argue that 'migrate_cancel' and
> 'migrate_set_downtime' are the odd ones out, and only because they were
> written before our current policy of preferring dash.
>
>> Shouldn't I stay consistent with the other commands?
>
> Yes, which is why I'm arguing for using dash.
Correct. Use dash instead of underscore for new commands and JSON
object member names.
[Qemu-devel] [RFC PATCH RDMA support v2: 3/6] install new monitor commands and setup RDMA capabilities, Michael R. Hines, 2013/02/11
[Qemu-devel] [RFC PATCH RDMA support v2: 2/6] create migration-rdma.c for core RDMA migration code, Michael R. Hines, 2013/02/11
[Qemu-devel] [RFC PATCH RDMA support v2: 5/6] connection-setup code between client/server, Michael R. Hines, 2013/02/11