Re: [Qemu-devel] [PATCH] qemu-log: default to stderr for logging output

[Andreas Färber]

Am 12.02.2013 18:58, schrieb Peter Maydell:
> On 12 February 2013 17:50, Andreas Färber <address@hidden> wrote:
>> Am 12.02.2013 18:33, schrieb Peter Maydell:
>>> Stefan suggested that qemu_log should default to stderr, and I
>>> agree that it makes more sense than a random file in /tmp/.
>>> As noted in the commit message, this is technically an incompatible
>>> change.
>>
>> I don't think this change is okay, it should be limited to the softmmus.
>> Having random debug output appear on stderr may well break linux-user
>> test suites or use cases.
> 
> Debug output will only appear on stderr if you asked for it by
> passing -d something. This isn't any different to the softmmu
> case (where it is also the case that random debug output might
> break things, and also that you won't get it unless you ask).
> 
> I agree that it might break weird use cases (where you're running
> some existing scripted usecase with debug logging enabled for some
> reason); the tradeoff for those people having to tweak their script
> to add "-D /tmp/qemu.log" is that we make things better for the
> common user who mostly doesn't run with debug but who can now run
> with '-d unimp,guest_errors' and get those messages usefully
> interspersed with guest output.

I was thinking of default options, so if nothing gets printed by default
that's okay with me.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg