Re: [Qemu-devel] [PATCH v10 0/4] Add subcommand compare for qemu-img

[Kevin Wolf]

Am 12.02.2013 08:00, schrieb Miroslav Rezanina:
> This is 10th version of patch adding compare subcommand that
> compares two images. Compare has following criteria:
>  - only data part is compared
>  - unallocated sectors are not read
>  to be zeroed/unallocated to compare rest
>  - qemu-img returns:
>     - 0 if images are identical
>     - 1 if images differ
>     - >2 error on execution

> Miroslav Rezanina (4):
>   block: Add synchronous wrapper for bdrv_co_is_allocated_above
>   qemu-img: Add "Quiet mode" option
>   This patch adds new qemu-img subcommand that compares content of two
>     disk     images.
>   qemu-iotests: Add qemu-img compare test
> 
>  block.c                    |   51 +++++-
>  blockdev.c                 |    6 +-
>  include/block/block.h      |    5 +-
>  qemu-img-cmds.hx           |   34 ++--
>  qemu-img.c                 |  441 
> +++++++++++++++++++++++++++++++++++++++-----
>  qemu-img.texi              |   56 ++++++
>  tests/qemu-iotests/048     |   77 ++++++++
>  tests/qemu-iotests/048.out |   25 +++
>  tests/qemu-iotests/group   |    1 +
>  9 files changed, 626 insertions(+), 70 deletions(-)
>  create mode 100755 tests/qemu-iotests/048
>  create mode 100644 tests/qemu-iotests/048.out

I had only minor comments that could as well be addressed on top.

Reviewed-by: Kevin Wolf <address@hidden>