[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 01/10] mips-linux-user: Delete n32 and n64 signa
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH 01/10] mips-linux-user: Delete n32 and n64 signal stubs |
Date: |
Mon, 11 Feb 2013 18:05:55 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130105 Thunderbird/17.0.2 |
Am 11.02.2013 17:02, schrieb Richard Henderson:
> On 2013-02-10 10:30, Richard Henderson wrote:
>> Signed-off-by: Richard Henderson <address@hidden>
>
> Deleting these first makes the next patch much easier to read.
> This doesn't cause any sort of compilation failure because we
> have not yet enabled n32/n64 compilation. This is dead code.
We have it enabled for openSUSE despite the #warning (anyone can enable
it via --target-list, so it's not entirely dead code), but since you're
fixing it later in the series that seems fine with me. Ideally you could
squash patches 1+2 so that there is no regression.
I'll try putting these into our package's patch queue later today.
Thanks for working on fixing this!
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- [Qemu-devel] [PATCH 00/10] Support mips64/mipsn32-linux-user, Richard Henderson, 2013/02/10
- [Qemu-devel] [PATCH 02/10] mips-linux-user: Share o32 code for n32 and n64 signals, Richard Henderson, 2013/02/10
- [Qemu-devel] [PATCH 03/10] mips-linux-user: Enable mips64 and mipsn32 linux-user targets, Richard Henderson, 2013/02/10
- [Qemu-devel] [PATCH 06/10] mips64-linux-user: Enable 64-bit address mode and fpu, Richard Henderson, 2013/02/10
- [Qemu-devel] [PATCH 05/10] mips-linux-user: Fix n32 and n64 syscalls, Richard Henderson, 2013/02/10