[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-1.4 v2 1/5] qtest: Use strtoull() for uint64
From: |
Anthony Liguori |
Subject: |
Re: [Qemu-devel] [PATCH for-1.4 v2 1/5] qtest: Use strtoull() for uint64_t |
Date: |
Fri, 08 Feb 2013 15:35:09 -0600 |
User-agent: |
Notmuch/0.13.2+93~ged93d79 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) |
Andreas Färber <address@hidden> writes:
> On 32-bit hosts, unsigned long may be uint32_t and uint64_t may be
> unsigned long long. Account for this by always using strtoull().
> We were already using strtoll() for int64_t.
>
> Signed-off-by: Andreas Färber <address@hidden>
Reviewed-by: Anthony Liguori <address@hidden>
Regards,
Anthony Liguori
> ---
> qtest.c | 8 ++++----
> 1 Datei geändert, 4 Zeilen hinzugefügt(+), 4 Zeilen entfernt(-)
>
> diff --git a/qtest.c b/qtest.c
> index b7a3821..4663a38 100644
> --- a/qtest.c
> +++ b/qtest.c
> @@ -282,8 +282,8 @@ static void qtest_process_command(CharDriverState *chr,
> gchar **words)
> uint8_t *data;
>
> g_assert(words[1] && words[2]);
> - addr = strtoul(words[1], NULL, 0);
> - len = strtoul(words[2], NULL, 0);
> + addr = strtoull(words[1], NULL, 0);
> + len = strtoull(words[2], NULL, 0);
>
> data = g_malloc(len);
> cpu_physical_memory_read(addr, data, len);
> @@ -302,8 +302,8 @@ static void qtest_process_command(CharDriverState *chr,
> gchar **words)
> size_t data_len;
>
> g_assert(words[1] && words[2] && words[3]);
> - addr = strtoul(words[1], NULL, 0);
> - len = strtoul(words[2], NULL, 0);
> + addr = strtoull(words[1], NULL, 0);
> + len = strtoull(words[2], NULL, 0);
>
> data_len = strlen(words[3]);
> if (data_len < 3) {
> --
> 1.7.10.4
- [Qemu-devel] [PATCH RFC v2 0/5] qtest: tmp105-test BE fix for 1.4 and MMIO support, Andreas Färber, 2013/02/06
- [Qemu-devel] [PATCH for-1.4 v2 1/5] qtest: Use strtoull() for uint64_t, Andreas Färber, 2013/02/06
- Re: [Qemu-devel] [PATCH for-1.4 v2 1/5] qtest: Use strtoull() for uint64_t,
Anthony Liguori <=
- [Qemu-devel] [PATCH for-1.4? v2 3/5] tmp105-test: Combine assertions of 16-bit responses, Andreas Färber, 2013/02/06
- [Qemu-devel] [RFC v2 5/5] qtest: Add MMIO support, Andreas Färber, 2013/02/06
- [Qemu-devel] [PATCH for-1.4 v2 2/5] libi2c-omap: Fix endianness dependency, Andreas Färber, 2013/02/06
- [Qemu-devel] [PATCH v2 4/5] tmp105: Add debug output, Andreas Färber, 2013/02/06
- Re: [Qemu-devel] [PATCH RFC v2 0/5] qtest: tmp105-test BE fix for 1.4 and MMIO support, Anthony Liguori, 2013/02/12