[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH for-1.4 v2 2/6] error: Clean up abuse of error_repor
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH for-1.4 v2 2/6] error: Clean up abuse of error_report() for help |
Date: |
Fri, 8 Feb 2013 17:17:08 +0100 |
Use error_printf() instead, so the help gets presented more nicely.
Signed-off-by: Markus Armbruster <address@hidden>
---
hw/vfio_pci.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/vfio_pci.c b/hw/vfio_pci.c
index 66537b7..a934f13 100644
--- a/hw/vfio_pci.c
+++ b/hw/vfio_pci.c
@@ -1806,9 +1806,9 @@ static int vfio_get_device(VFIOGroup *group, const char
*name, VFIODevice *vdev)
ret = ioctl(group->fd, VFIO_GROUP_GET_DEVICE_FD, name);
if (ret < 0) {
- error_report("vfio: error getting device %s from group %d: %m\n",
+ error_report("vfio: error getting device %s from group %d: %m",
name, group->groupid);
- error_report("Verify all devices in group %d are bound to vfio-pci "
+ error_printf("Verify all devices in group %d are bound to vfio-pci "
"or pci-stub and not already in use\n", group->groupid);
return ret;
}
--
1.7.11.7
- Re: [Qemu-devel] [PATCH for-1.4 v2 4/6] qemu-option: Disable two helpful messages that got broken recently, (continued)
[Qemu-devel] [PATCH for-1.4 v2 1/6] error: Clean up error strings with embedded newlines, Markus Armbruster, 2013/02/08
[Qemu-devel] [PATCH for-1.4 v2 6/6] vl: Exit unsuccessfully on option argument syntax error, Markus Armbruster, 2013/02/08
[Qemu-devel] [PATCH for-1.4 v2 2/6] error: Clean up abuse of error_report() for help,
Markus Armbruster <=
[Qemu-devel] [PATCH for-1.4 v2 5/6] vl: Drop redundant "parse error" reports, Markus Armbruster, 2013/02/08
[Qemu-devel] [PATCH for-1.4 v2 3/6] error: Strip trailing '\n' from error string arguments (again), Markus Armbruster, 2013/02/08
Re: [Qemu-devel] [PATCH for-1.4 v2 0/6] Error reporting fixes, Markus Armbruster, 2013/02/08