Re: [Qemu-devel] [PATCH] target-i386: n270 can MOVBE

[Paolo Bonzini]

Il 08/02/2013 16:10, Eduardo Habkost ha scritto:
> On Fri, Feb 08, 2013 at 02:59:25PM +0100, Paolo Bonzini wrote:
>> Il 08/02/2013 14:44, Andreas Färber ha scritto:
>>>>>>> Otherwise if someone can ack (or if you can point me to a manual), this
>>>>>>> looks like a good bugfix for v1.4.
>>>>>
>>>>> Right, I don't know what v1.4 is
>>> It's the QEMU release that we're about to make in a week. :-)
>>> http://wiki.qemu.org/Planning/1.4
>>>
>>>>> but this still needs Richard's patchset
>>>>> enabling MOVBE dynamic translation in qemu to go in first before
>>>>> enabling MOVBE for the n270 model.
>>> OK, so this goes through Richard's queue then, no objections.
>>
>> I'm not sure I understand the relationship between QEMU CPUID bits and
>> TCG/KVM, but perhaps this could go in 1.4 for KVM.
>>
>> Does TCG have a way to mask bits that aren't supported in the
>> translator?  For example AVX that is enabled by SandyBridge.
> 
> TCG mode automatically masks the bits not supported by TCG, see how
> x86_cpu_realizefn() uses TCG_FEATURES/TCG_EXT_FEATURES/etc.

Uh, but n270 doesn't support vmx. :(  Too bad.  Then this patch indeed
is not needed in 1.4.

Paolo