qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 08/10] aio: extract aio_dispatch() from aio_p


From: Laszlo Ersek
Subject: Re: [Qemu-devel] [PATCH v3 08/10] aio: extract aio_dispatch() from aio_poll()
Date: Wed, 06 Feb 2013 19:24:42 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130108 Thunderbird/10.0.12

On 02/04/13 13:12, Stefan Hajnoczi wrote:
> We will need to loop over AioHandlers calling ->io_read()/->io_write()
> when aio_poll() is converted from select(2) to g_poll(2).
> 
> Luckily the code for this already exists, extract it into the new
> aio_dispatch() function.
> 
> Two small changes:
> 
>  * aio_poll() checks !node->deleted to avoid calling handlers that have
>    been deleted.

This is actually an unrelated bugfix, isn't it?

> 
>  * Fix typo 'then' -> 'them' in aio_poll() comment.
> 
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
>  aio-posix.c | 57 +++++++++++++++++++++++++++++++++++----------------------
>  1 file changed, 35 insertions(+), 22 deletions(-)

Reviewed-by: Laszlo Ersek <address@hidden>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]