Re: [Qemu-devel] [PATCH for-1.4 05/12] qmp: Drop superfluous special case "empty" in qmp_memchar_read()

[Eric Blake]

On 02/05/2013 09:22 AM, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>  qemu-char.c | 4 ----
>  1 file changed, 4 deletions(-)

Reviewed-by: Eric Blake <address@hidden>

> 
> diff --git a/qemu-char.c b/qemu-char.c
> index 9bf53e0..036ca2c 100644
> --- a/qemu-char.c
> +++ b/qemu-char.c
> @@ -2818,10 +2818,6 @@ char *qmp_memchar_read(const char *device, int64_t 
> size,
>      }
>  
>      count = qemu_chr_cirmem_count(chr);
> -    if (count == 0) {
> -        return g_strdup("");
> -    }
> -
>      size = size > count ? count : size;
>      read_data = g_malloc0(size + 1);
>  
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature