[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] get_tmp_filename: add explicit error message
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH] get_tmp_filename: add explicit error message |
Date: |
Mon, 4 Feb 2013 09:39:00 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Fri, Feb 01, 2013 at 06:13:51PM +0100, Fabien Chouteau wrote:
>
> Signed-off-by: Fabien Chouteau <address@hidden>
> ---
> block.c | 13 ++++++++++---
> 1 file changed, 10 insertions(+), 3 deletions(-)
Hi Fabien,
Please always CC address@hidden All patches must be on
qemu-devel so that the community can review them - not everyone
subscribes to qemu-trivial.
Thanks,
Stefan
> diff --git a/block.c b/block.c
> index ba67c0d..3bf8eda 100644
> --- a/block.c
> +++ b/block.c
> @@ -428,9 +428,16 @@ int get_tmp_filename(char *filename, int size)
> /* GetTempFileName requires that its output buffer (4th param)
> have length MAX_PATH or greater. */
> assert(size >= MAX_PATH);
> - return (GetTempPath(MAX_PATH, temp_dir)
> - && GetTempFileName(temp_dir, "qem", 0, filename)
> - ? 0 : -GetLastError());
> + if (GetTempPath(MAX_PATH, temp_dir) == 0) {
> + fprintf(stderr, "GetTempPath() error: %d\n", GetLastError());
> + return -GetLastError();
> + }
> + if (GetTempFileName(temp_dir, "qem", 0, filename) == 0) {
> + fprintf(stderr, "GetTempFileName(%s) error: %d\n", temp_dir,
> + GetLastError());
> + return -GetLastError();
> + }
> + return 0;
> #else
> int fd;
> const char *tmpdir;
> --
> 1.7.9.5
>
- Re: [Qemu-devel] [PATCH] get_tmp_filename: add explicit error message,
Stefan Hajnoczi <=