[Qemu-devel] [PATCH 0/7] propagate Errors to do_device_add()

[Laszlo Ersek]

This series is the first in converting do_device_add() to qapi.

The following call chains have been modified:

  do_device_add -> qemu_find_opts -> error_report
  do_device_add -> qdev_device_add -> qerror_report
  do_device_add -> qdev_device_add -> qbus_find -> qbus_find_recursive -> 
qerror_report
  do_device_add -> qdev_device_add -> qbus_find -> qerror_report
  do_device_add -> qdev_device_add -> set_property -> qdev_prop_parse -> 
qerror_report_err

The following call chains
- all depend on !monitor_cur_is_qmp() at some level (marked with *),
- all print informative messages (not errors per se),
- are the next step in the conversion -- ultimately they belong in HMP:

  do_device_add -> qemu_opts_from_qdict -> qemu_opts_create -> 
error_printf_unless_qmp*
  do_device_add -> qemu_opts_from_qdict -> qemu_opts_from_qdict_1 -> 
qemu_opt_set_err -> opt_set -> qemu_opt_parse -> parse_option_size -> 
error_printf_unless_qmp*
  do_device_add* -> qdev_device_help -> qdev_print_devinfo -> error_printf
  do_device_add* -> qdev_device_help -> error_printf
  do_device_add -> qdev_device_add -> qbus_find* -> qbus_list_dev -> 
error_printf
  do_device_add -> qdev_device_add -> qbus_find* -> qbus_list_bus -> 
error_printf

Laszlo Ersek (7):
  remove some trailing whitespace
  do_device_add(): look up "device" opts list with qemu_find_opts_err()
  qdev_prop_parse(): report errors via Error
  qbus_find_recursive(): reorganize
  qbus_find_recursive(): terminate search by name in case of fatal
    error
  qbus_find(): report errors via Error
  qdev_device_add(): report errors with Error

 hw/qdev-monitor.h    |    3 +-
 hw/qdev-properties.h |    4 +-
 hw/qdev-monitor.c    |  124 ++++++++++++++++++++++++++++++--------------------
 hw/qdev-properties.c |   12 +++--
 vl.c                 |   17 ++++--
 5 files changed, 99 insertions(+), 61 deletions(-)