qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH V4 00/22] Multiqueue virtio-net


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH V4 00/22] Multiqueue virtio-net
Date: Thu, 31 Jan 2013 08:18:51 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2

On 01/31/2013 06:58 AM, Michael S. Tsirkin wrote:

>>> For hotplug, it just work if you pass multiple file descriptors one by
>>> one through getfd and then use fds=X:Y,vhostfds=M:N.
>>
>> For hotplug, you can't pass integers; you have to name the fds either
>> way.  Either you name it with getfd, or you name it with add-fd.  But
>> getfd is not as nice as add-fd when it comes to ensuring that fds are
>> not leaked in qemu, even when the management app such as libvirt
>> restarts.  Furthermore, if it is possible to specify taps by pathname
>> instead of by fd inheritance,
> 
> I don't think there's a way to specify taps by pathname.

Then using fds=integer:integer on the command line makes the most sense,
and QMP uses fds=name:name where name was specified by 'getfd', and
there is no way to wire up qemu_open() nor any need to use 'add-fd'.
Okay, my question has been answered, your approach looks right now that
I know more about how -netdev works to begin with.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]