Re: [Qemu-devel] [PATCH] Fix monitor 'info registers' command on multi processor guests

[Markus Armbruster]

Luiz Capitulino <address@hidden> writes:

> On Thu, 31 Jan 2013 10:51:10 +0100
> Markus Armbruster <address@hidden> wrote:
>
>> "Erlon Cruz" <address@hidden> writes:
>> 
>> > QEMU monitor command 'info registers' only displays information
>> > for the first
>> > CPU. This fix that by show registers information for each CPU in the system
>> 
>> This is incorrect.  It displays information for the *current* CPU.
>> Monitor command "cpu" selects the current CPU.
>> 
>> I doubt we want to change this command.  But I'm reviewing it regardless
>> of my doubts.
>
> I think a better way of doing this would be to add two new optional
> arguments to 'info registers': -i (cpu index) and -a (print all CPUs). By
> default the command would do what it does today.

Sounds good to me.