Re: [Qemu-devel] [kvmarm] [RFC v5 7/8] hw/kvm/arm_gic: Implement support for KVM in-kernel ARM GIC

[Peter Maydell]

On 31 January 2013 10:54, Andreas Färber <address@hidden> wrote:
> Am 31.01.2013 11:52, schrieb KONRAD Frédéric:
>>> +    const char *gictype = "arm-gic";
>> s/arm-gic/arm_gic/                 ^^ ?
>>
>> Christoffer and I had trouble with that:
>>
>> qemu-system-arm: Unknown device 'arm-gic' for default sysbus

Oops, nice catch.

> Since you already ran into issues here, even better would be to use a
> TYPE_ARM_GIC constant or so.

Hmm, I kind of agree, but QOM idiom doesn't seem to encourage
having that define be publicly visible. Should we have a
hw/my_device.h [with the public bits like the TYPE_ and
FOO_CLASS/FOO_GET_CLASS macros] for every type? (and a
hw/my_device_priv.h if needed]

-- PMM