Re: [Qemu-devel] [PATCH 0/7] usb-host: switch to libusb

[Andreas Färber]

Hi,

Am 25.01.2013 15:26, schrieb Hans de Goede:
> On 01/24/2013 04:41 PM, Gerd Hoffmann wrote:
>> This is the usb patch queue for review.  It features a new usb-host
>> implementation which is based on libusb now (patch #7).  The other
>> patches are small cleanups and preparations.
> 
> Cool stuff I esp. like 5/7 and 6/7 as those were on my to-do list :)

I like the idea of the libusb based host support 7/7.

> As for the following comment in 7/7:
> 
> The bsd driver isn't qdev'ified so it isn't that easy for bsd.
> I didn't bother making it runtime switchable, so you have to rebuild
> qemu with --disable-libusb to get back the old code.

On FreeBSD 8 or 9 the host code no longer compiles anyway due to a
rewrite of their USB stack, if it does with the new default
implementation then that's an improvement.

> I don't think that will be any loss, I've looked at the bsd host
> code a couple of times while adjusting it for core usb changes and
> it only offers very limited functionality. I hope that the
> functionality offered on BSD through libusb will be better.

CC'ing some BSD folks here. :)

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg