[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH][TRIVIAL] vl: coding style cleanups
From: |
Alexander Graf |
Subject: |
Re: [Qemu-devel] [PATCH][TRIVIAL] vl: coding style cleanups |
Date: |
Fri, 25 Jan 2013 10:56:00 +0100 |
Am 25.01.2013 um 10:47 schrieb Andreas Färber <address@hidden>:
> Hi,
>
> Am 25.01.2013 00:04, schrieb Jesse Larrew:
>>
>> Reformat the option parsing code in main() and various supporting functions
>> to conform to the QEMU coding style.
>>
>> Signed-off-by: Jesse Larrew <address@hidden>
>> ---
>> vl.c | 476
>> +++++++++++++++++++++++++++++++++++++------------------------------
>> 1 file changed, 260 insertions(+), 216 deletions(-)
>
> On a brief look this doesn't look wrong. What is the purpose of this
> patch though? Is it intended for the s390x SCLP patch to be rebased
> upon, or is it preparing some other actual refactoring or addition?
> We don't usually do pure Coding Style refactorings without follow-ups.
We only don't do it because nobody wanted to sit down and actually convert the
code to adhere to the "new" coding style guidelines.
I think it's a great idea to fix vl.c's coding style once and for all.
Alex
>
> Regards,
> Andreas
>
> --
> SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
> GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg