[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC V7 03/11] quorum: Add quorum_open() and quorum_clo
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [RFC V7 03/11] quorum: Add quorum_open() and quorum_close(). |
Date: |
Tue, 22 Jan 2013 14:51:33 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 |
On 01/18/2013 10:30 AM, Benoît Canet wrote:
> Valid quorum resources look like
> quorum:threshold/total:path/to/image_1: ... :path/to/image_total
>
> ':' is used as a separator
> '\' is the escaping character for filename containing ':'
> '\' escape itself
These are true of the protocol itself,
> ',' must be escaped with ','
while this is true only of the qemu command line parser (but not if we
had a direct C interface into opening the protocol directly). But I'm
okay with the commit message.
>
> On the command line for quorum files "img:test.raw", "img2,raw"
> and "img3.raw" invocation look like:
>
> -drive file=quorum:2/3:img\\:test.raw:img2,,raw:img3.raw
> (note the double \\ and the double ,,)
>
> Signed-off-by: Benoit Canet <address@hidden>
> ---
> block/quorum.c | 155
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 155 insertions(+)
> +static int quorum_parse_uint_step_next(const char *start,
> + }
> + ret = parse_uint(start, value, next, 10);
Any reason to force decimal here, instead of allowing octal and hex by
passing 0 for base? But I'm not too worried if you leave it this way.
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [RFC V7 00/11] Quorum block filter, Benoît Canet, 2013/01/18
- [Qemu-devel] [RFC V7 02/11] quorum: Create BDRVQuorumState and BlkDriver and do init., Benoît Canet, 2013/01/18
- [Qemu-devel] [RFC V7 01/11] quorum: Create quorum .c, add QuorumSingleAIOCB and QuorumAIOCB., Benoît Canet, 2013/01/18
- [Qemu-devel] [RFC V7 04/11] quorum: Add quorum_aio_writev and its dependencies., Benoît Canet, 2013/01/18
- [Qemu-devel] [RFC V7 03/11] quorum: Add quorum_open() and quorum_close()., Benoît Canet, 2013/01/18
- Re: [Qemu-devel] [RFC V7 03/11] quorum: Add quorum_open() and quorum_close().,
Eric Blake <=
- [Qemu-devel] [RFC V7 06/11] quorum: Add quorum_aio_readv., Benoît Canet, 2013/01/18
- [Qemu-devel] [RFC V7 05/11] blkverify: Extract qemu_iovec_clone() and qemu_iovec_compare() from blkverify., Benoît Canet, 2013/01/18
- [Qemu-devel] [RFC V7 08/11] quorum: Add quorum_getlength()., Benoît Canet, 2013/01/18
- [Qemu-devel] [RFC V7 09/11] quorum: Add quorum_invalidate_cache()., Benoît Canet, 2013/01/18
- [Qemu-devel] [RFC V7 10/11] quorum: Add quorum_co_is_allocated., Benoît Canet, 2013/01/18
- [Qemu-devel] [RFC V7 11/11] quorum: Add quorum_co_flush()., Benoît Canet, 2013/01/18
- [Qemu-devel] [RFC V7 07/11] quorum: Add quorum mechanism., Benoît Canet, 2013/01/18
- Re: [Qemu-devel] [RFC V7 00/11] Quorum block filter, Zhi Yong Wu, 2013/01/21