qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] Annotate questionable fallthroughs


From: Max Filippov
Subject: Re: [Qemu-devel] [PATCH] Annotate questionable fallthroughs
Date: Mon, 21 Jan 2013 17:37:04 +0300

On Mon, Jan 21, 2013 at 6:27 PM, Markus Armbruster <address@hidden> wrote:
> Max Filippov <address@hidden> writes:
>>>> diff --git a/target-xtensa/op_helper.c b/target-xtensa/op_helper.c
>>>> index 3813a72..d829702 100644
>>>> --- a/target-xtensa/op_helper.c
>>>> +++ b/target-xtensa/op_helper.c
>>>> @@ -443,8 +443,10 @@ void HELPER(check_atomctl)(CPUXtensaState *env, 
>>>> uint32_t pc, uint32_t vaddr)
>>>>      switch (access & PAGE_CACHE_MASK) {
>>>>      case PAGE_CACHE_WB:
>>>>          atomctl >>= 2;
>>>> +        /* XXX: questionable fallthrough */
>>>>      case PAGE_CACHE_WT:
>>>>          atomctl >>= 2;
>>>> +        /* XXX: questionable fallthrough */
>>>>      case PAGE_CACHE_BYPASS:
>>>>          if ((atomctl & 0x3) == 0) {
>>>>              HELPER(exception_cause_vaddr)(env, pc,
>>>
>>> Looks intentional.  Max Filippov?
>>
>> Correct, these are intentional.
>
> Thanks!  Who's going to take care of adding /* fall through */ ?

I will post a patch, I just got wrong impression that you wanted
them all fixed in one go.

-- 
Thanks.
-- Max



reply via email to

[Prev in Thread] Current Thread [Next in Thread]