[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 00/12] Drive mirroring performance improvemen
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH v2 00/12] Drive mirroring performance improvements |
Date: |
Mon, 21 Jan 2013 14:27:33 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120605 Thunderbird/13.0 |
Am 16.01.2013 18:31, schrieb Paolo Bonzini:
> The fixes from the previous post are:
>
> 1) the in_flight_bitmap is now properly set and cleared [Stefan];
>
> 2) persistent dirty bitmap left out [Stefan];
>
> 3) reordered arguments in qmp-command.hx to follow patch order [Stefan];
>
> 4) tests/qemu-iotests/041.out is regenerated;
>
> 5) rebased for moved include files and for the discard series
>
> Thanks!
>
> Paolo
>
> Paolo Bonzini (12):
> host-utils: add ffsl
> add hierarchical bitmap data type and test cases
> block: implement dirty bitmap using HBitmap
> block: make round_to_clusters public
> mirror: perform COW if the cluster size is bigger than the granularity
> block: return count of dirty sectors, not chunks
> block: allow customizing the granularity of the dirty bitmap
> mirror: allow customizing the granularity
> mirror: switch mirror_iteration to AIO
> mirror: add buf-size argument to drive-mirror
> mirror: support more than one in-flight AIO operation
> mirror: support arbitrarily-sized iterations
>
> block-migration.c | 7 +-
> block.c | 124 ++++----------
> block/mirror.c | 381 ++++++++++++++++++++++++++++++++++-------
> blockdev.c | 37 +++--
> hmp.c | 2 +-
> include/block/block.h | 11 +-
> include/block/block_int.h | 10 +-
> include/qemu/hbitmap.h | 207 ++++++++++++++++++++++
> include/qemu/host-utils.h | 26 +++
> qapi-schema.json | 15 ++-
> qmp-commands.hx | 10 +-
> tests/Makefile | 3 +
> tests/qemu-iotests/041 | 52 ++++++
> tests/qemu-iotests/041.out | 4 +-
> tests/test-hbitmap.c | 408
> ++++++++++++++++++++++++++++++++++++++++++++
> trace-events | 12 ++
> util/Makefile.objs | 2 +-
> util/hbitmap.c | 400 +++++++++++++++++++++++++++++++++++++++++++
> 18 files changed, 1527 insertions(+), 184 deletions(-)
> create mode 100644 include/qemu/hbitmap.h
> create mode 100644 tests/test-hbitmap.c
> create mode 100644 util/hbitmap.c
Completed my review now. All patches on which I didn't comment look okay.
Kevin
- Re: [Qemu-devel] [PATCH v2 09/12] mirror: switch mirror_iteration to AIO, (continued)
[Qemu-devel] [PATCH v2 10/12] mirror: add buf-size argument to drive-mirror, Paolo Bonzini, 2013/01/16
[Qemu-devel] [PATCH v2 11/12] mirror: support more than one in-flight AIO operation, Paolo Bonzini, 2013/01/16
[Qemu-devel] [PATCH v2 12/12] mirror: support arbitrarily-sized iterations, Paolo Bonzini, 2013/01/16
[Qemu-devel] [PATCH v2 06/12] block: return count of dirty sectors, not chunks, Paolo Bonzini, 2013/01/16
Re: [Qemu-devel] [PATCH v2 00/12] Drive mirroring performance improvements, Eric Blake, 2013/01/16
Re: [Qemu-devel] [PATCH v2 00/12] Drive mirroring performance improvements,
Kevin Wolf <=