Re: [Qemu-devel] [PATCH 06/18] hw: add QEMU model for Faraday I2C master controller

[Andreas Färber]

Am 18.01.2013 07:30, schrieb Dante:
> Signed-off-by: Kuo-Jung Su <address@hidden>

These patches are all for QEMU so please generally drop "QEMU model for"
from the subject for readability.

> ---
>  hw/fti2c010.c |  209 
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  hw/fti2c010.h |   77 +++++++++++++++++++++
>  2 files changed, 286 insertions(+)
>  create mode 100644 hw/fti2c010.c
>  create mode 100644 hw/fti2c010.h

This adds two files but misses to add them to a Makefile so that this
patch can actually be compile-tested.

I have recently added a test framework for I2C. Can you please add such
libqos support as tests/libi2c-fti2c010.c as a follow-up patch if you
haven't already somewhere in this series? This suggests similar
preparations as for the RTC, in this case extracting constants from
fti2c010.h to an fti2c010_regs.h while putting the QOM macros and
optionally state struct (if it is to be embedded in some other chipset)
into fti2c010.h.

Regards,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg