[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH V4 13/13] hmp: show snapshots on single block device
From: |
Wenchao Xia |
Subject: |
[Qemu-devel] [PATCH V4 13/13] hmp: show snapshots on single block device |
Date: |
Thu, 17 Jan 2013 15:40:10 +0800 |
This patch added the support of showing internal snapshots on a
single block device in hmp layer, by simply change parameter in
calling of qmp funtion.
Note:
This patch need previous hmp extention patch which enable
info sub command take qdict * as paramter.
Signed-off-by: Wenchao Xia <address@hidden>
---
hmp.c | 7 ++++++-
monitor.c | 6 +++---
2 files changed, 9 insertions(+), 4 deletions(-)
diff --git a/hmp.c b/hmp.c
index 1e8f9eb..4a6c3ee 100644
--- a/hmp.c
+++ b/hmp.c
@@ -655,8 +655,10 @@ void hmp_info_snapshots(Monitor *mon, const QDict *qdict)
{
Error *err = NULL;
SnapshotInfoList *list;
+ const char *device = qdict_get_try_str(qdict, "device");
+ bool has_device = device ? true : false;
- list = qmp_query_snapshots(false, NULL, &err);
+ list = qmp_query_snapshots(has_device, device, &err);
if (error_is_set(&err)) {
hmp_handle_error(mon, &err);
return;
@@ -667,6 +669,9 @@ void hmp_info_snapshots(Monitor *mon, const QDict *qdict)
return;
}
+ if (has_device) {
+ monitor_printf(mon, "Device '%s':\n", device);
+ }
monitor_dump_snapshotinfolist(mon, list);
qapi_free_SnapshotInfoList(list);
}
diff --git a/monitor.c b/monitor.c
index 4bb80c0..a2aa10c 100644
--- a/monitor.c
+++ b/monitor.c
@@ -2591,9 +2591,9 @@ static mon_cmd_t info_cmds[] = {
},
{
.name = "snapshots",
- .args_type = "",
- .params = "",
- .help = "show the currently saved VM snapshots",
+ .args_type = "device:B?",
+ .params = "[device]",
+ .help = "show snapshots of whole vm or a single device",
.mhandler.cmd = hmp_info_snapshots,
},
{
--
1.7.1
- Re: [Qemu-devel] [PATCH V4 04/13] block: add snapshot info query function bdrv_query_snapshot_infolist(), (continued)
- [Qemu-devel] [PATCH V4 05/13] block: add image info query function bdrv_query_image_info(), Wenchao Xia, 2013/01/17
- [Qemu-devel] [PATCH V4 06/13] qemu-img: switch image retrieving function, Wenchao Xia, 2013/01/17
- [Qemu-devel] [PATCH V4 07/13] block: rename bdrv_query_info to bdrv_query_block_info, Wenchao Xia, 2013/01/17
- [Qemu-devel] [PATCH V4 08/13] qmp: add interface query-images., Wenchao Xia, 2013/01/17
- [Qemu-devel] [PATCH V4 09/13] block: export function bdrv_find_snapshot(), Wenchao Xia, 2013/01/17
- [Qemu-devel] [PATCH V4 11/13] hmp: add function hmp_info_snapshots(), Wenchao Xia, 2013/01/17
- [Qemu-devel] [PATCH V4 10/13] qmp: add interface query-snapshots, Wenchao Xia, 2013/01/17
- [Qemu-devel] [PATCH V4 12/13] hmp: switch snapshot info function to qmp based one, Wenchao Xia, 2013/01/17
- [Qemu-devel] [PATCH V4 13/13] hmp: show snapshots on single block device,
Wenchao Xia <=
- Re: [Qemu-devel] [PATCH V4 00/13] add qmp/hmp interfaces for snapshot info, Wenchao Xia, 2013/01/21