[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] build: fix Win32 clean build
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH] build: fix Win32 clean build |
|
Date: |
Wed, 16 Jan 2013 18:40:59 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 |
Il 15/01/2013 18:34, Stefan Weil ha scritto:
>
> Tested-by: Stefan Weil <address@hidden>
>
> Blue, Paolo's patch fixes a recently introduced build regression for MinGW.
> Please apply it to git master.
>
> I won't send a pull request because it is a build fix.
>
> Paolo, your latest modifications added one more regression
> because MinGW builds now compile files which are only needed
> for user mode (= never for MinGW).util/envlist.c uses strtok_r
> which is unavailable for MinGW, so we get a compiler warning,
> but no linker error because it is unused.
Yeah, this is a side effect of having an understandable directory
layout. :) However I'd prefer if we added strtok_r to oslib-win32.c to
silence the warning, even if it's dead code.
Paolo