Re: [Qemu-devel] [PATCH] bswap: improve gluing

[Andreas Färber]

Am 13.01.2013 17:35, schrieb Blue Swirl:
> OpenBSD system compiler (gcc 4.2.1) has problems with concatenation
> of macro arguments in macro functions:
>   CC    aes.o
> In file included from /src/qemu/include/qemu-common.h:126,
>                  from /src/qemu/aes.c:30:
> /src/qemu/include/qemu/bswap.h: In function 'leul_to_cpu':
> /src/qemu/include/qemu/bswap.h:461: warning: implicit declaration of function 
> 'bswapHOST_LONG_BITS'
> /src/qemu/include/qemu/bswap.h:461: warning: nested extern declaration of 
> 'bswapHOST_LONG_BITS'
> 
> Function leul_to_cpu() is only used in kvm-all.c, so the warnings
> are not fatal on OpenBSD without -Werror.
> 
> Fix by applying glue(). Also add do {} while(0) wrapping and fix
> semicolon use while at it.
> 
> Signed-off-by: Blue Swirl <address@hidden>

Tested-by: Andreas Färber <address@hidden>

This unbreaks the build on openSUSE 12.2 ppc64:
gcc (SUSE Linux) 4.7.1 20120723 [gcc-4_7-branch revision 189773]

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg