[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V5 4/6] HMP: filter out space before check of su
From: |
Luiz Capitulino |
Subject: |
Re: [Qemu-devel] [PATCH V5 4/6] HMP: filter out space before check of sub-command |
Date: |
Mon, 14 Jan 2013 13:33:28 -0200 |
On Mon, 14 Jan 2013 14:46:35 +0100
Markus Armbruster <address@hidden> wrote:
> Wenchao Xia <address@hidden> writes:
>
> > δΊ 2013-1-12 4:12, Luiz Capitulino ει:
> >> On Fri, 11 Jan 2013 17:14:03 +0800
> >> Wenchao Xia <address@hidden> wrote:
> >>
> >>> This fix the case when user input "@command ". Original
> >>> it will return NULL for monitor_parse_command(), now
> >>> it will return the @command related instance.
> >>>
> >>> Signed-off-by: Wenchao Xia <address@hidden>
> >>> ---
> >>> monitor.c | 3 +++
> >>> 1 files changed, 3 insertions(+), 0 deletions(-)
> >>>
> >>> diff --git a/monitor.c b/monitor.c
> >>> index 5435dc3..7b752a2 100644
> >>> --- a/monitor.c
> >>> +++ b/monitor.c
> >>> @@ -3588,6 +3588,9 @@ static const mon_cmd_t
> >>> *monitor_parse_command(Monitor *mon,
> >>> if (cmd->sub_table != NULL) {
> >>> p1 = p;
> >>> /* check if user set additional command */
> >>> + while (qemu_isspace(*p1)) {
> >>> + p1++;
> >>> + }
> >>
> >> Is there a reason for this to be in a different patch? I mean, why don't
> >> you squash this into the previous patch?
> >>
> > Markus suggest to do it
>
> Misunderstanding, sorry. My point was we skip over whitespace twice:
> first here, and then again in monitor_parse_command(). Quote:
That was my point in my second paragraph (which cut out).
[Qemu-devel] [PATCH V5 3/6] HMP: add infrastructure for sub command, Wenchao Xia, 2013/01/11
[Qemu-devel] [PATCH V5 6/6] HMP: add sub command table to info, Wenchao Xia, 2013/01/11
[Qemu-devel] [PATCH V5 1/6] HMP: add QDict to info callback handler, Wenchao Xia, 2013/01/11