Re: [Qemu-devel] [PATCH 01/10] ppc/newworld: add ISA bus, required by VGA card

[Andreas Färber]

Am 04.01.2013 22:29, schrieb Hervé Poussineau:
> Signed-off-by: Hervé Poussineau <address@hidden>
> ---
>  hw/ppc_newworld.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/ppc_newworld.c b/hw/ppc_newworld.c
> index fabcc08..cd30f42 100644
> --- a/hw/ppc_newworld.c
> +++ b/hw/ppc_newworld.c
> @@ -274,6 +274,7 @@ static void ppc_core99_init(QEMUMachineInitArgs *args)
>      }
>  
>      /* Register 8 MB of ISA IO space */
> +    isa_bus_new(NULL, get_system_io());
>      isa_mmio_init(0xf2000000, 0x00800000);
>  
>      /* UniN init */

I understand that a bus will be necessary for the ISA I/O ports, but I
do not like the bus added to the machine like this when at the same time
we are trying to QOM'ify the chipsets for IDE.

Where does this device logically sit? On UniNorth chipset?

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg