[Qemu-devel] [Bug 1090558] Re: hw/mc146818: error reading RTC_HOURS_ALARM

[Paolo Bonzini]

The problem is obviously there, but I tried pretty hard to make it fail
and couldn't so it seems latent.  If you can, please provide a patch to
tests/rtc-test.c that shows the bug.

** Changed in: qemu
       Status: New => Incomplete

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1090558

Title:
  hw/mc146818: error reading RTC_HOURS_ALARM

Status in QEMU:
  Incomplete

Bug description:
  get_next_alarm() doesn't read the RTC_HOURS_ALARM field correctly.

  - Bit 7 must be masked before conversion from BCD.
  - Care must be taken to check the don't care condition before masking.
  - The PM bit must be read from RTC_HOURS_ALARM, not from RTC_HOURS (as is 
done in convert_hour()).

  Seen in commit e376a788ae130454ad5e797f60cb70d0308babb6.

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1090558/+subscriptions