[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V4 2/4] HMP: add infrastructure for sub command
From: |
Wenchao Xia |
Subject: |
Re: [Qemu-devel] [PATCH V4 2/4] HMP: add infrastructure for sub command |
Date: |
Fri, 11 Jan 2013 11:11:44 +0800 |
User-agent: |
Mozilla/5.0 (Windows NT 5.1; rv:17.0) Gecko/17.0 Thunderbird/17.0 |
δΊ 2013-1-10 18:23, Markus Armbruster ει:
> Wenchao Xia <address@hidden> writes:
>
>> This patch make parsing of hmp command aware of that it may
>> have sub command. Also discard simple encapsulation function
>> monitor_find_command() and qmp_find_cmd().
>>
>> Signed-off-by: Wenchao Xia <address@hidden>
>> ---
>> monitor.c | 31 +++++++++++++++++++++++--------
>> 1 files changed, 23 insertions(+), 8 deletions(-)
>>
>> diff --git a/monitor.c b/monitor.c
>> index c7b3014..d49a362 100644
>> --- a/monitor.c
>> +++ b/monitor.c
>> @@ -130,6 +130,7 @@ typedef struct mon_cmd_t {
>> MonitorCompletion *cb, void *opaque);
>> } mhandler;
>> int flags;
>> + struct mon_cmd_t *sub_table;
>> } mon_cmd_t;
>>
>> /* file descriptors passed via SCM_RIGHTS */
>
> Forgot to mention: please explain in a comment how mhandler and
> sub_table interact. Namely, if there are arguments, we use sub_table,
> else mhandler.
>
OK.
--
Best Regards
Wenchao Xia