[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] MIPS: Translate breaks and traps into the appro
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH] MIPS: Translate breaks and traps into the appropriate signal |
Date: |
Thu, 10 Jan 2013 22:12:44 +0000 |
On 10 January 2013 21:46, Meador Inge <address@hidden> wrote:
> --- a/target-mips/cpu.h
> +++ b/target-mips/cpu.h
> @@ -620,6 +620,12 @@ enum {
> /* Dummy exception for conditional stores. */
> #define EXCP_SC 0x100
>
> +/* Break codes */
> +enum {
> + BRK_OVERFLOW = 6,
> + BRK_DIVZERO = 7
> +};
This is an OS/ABI specific define, right? I don't think it
belongs in the target-mips header file. Since it only has one
user, I think you could reasonably just put it in linux-user/main.c.
-- PMM