[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 10/10] chardev: add pty chardev support to ch
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 10/10] chardev: add pty chardev support to chardev-add (qmp) |
Date: |
Thu, 10 Jan 2013 12:45:28 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 |
On 01/10/2013 07:23 AM, Gerd Hoffmann wrote:
> The ptsname is returned directly, so there is no need to
> use query-chardev to figure the pty device path.
>
> Signed-off-by: Gerd Hoffmann <address@hidden>
> ---
> qapi-schema.json | 3 ++-
> qemu-char.c | 13 +++++++++++++
> qmp-commands.hx | 5 +++++
> 3 files changed, 20 insertions(+), 1 deletions(-)
> +++ b/qmp-commands.hx
> @@ -2685,6 +2685,11 @@ Examples:
> "data" : { "out" : "/tmp/bar.log" } } } }
> <- { "return": {} }
>
> +-> { "execute" : "chardev-add",
> + "arguments" : { "id" : "baz",
> + "backend" : { "type" : "pty", "data" : {} } } }
> +<- { "return": { "pty" : "/dev/pty/42" } }
I like it. The QMP API is looking saner now, although I still pointed
out enough questions that you might need a v3.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 02/10] chardev: fix QemuOpts lifecycle, (continued)
- [Qemu-devel] [PATCH v2 02/10] chardev: fix QemuOpts lifecycle, Gerd Hoffmann, 2013/01/10
- [Qemu-devel] [PATCH v2 06/10] chardev: add file chardev support to chardev-add (qmp), Gerd Hoffmann, 2013/01/10
- [Qemu-devel] [PATCH v2 03/10] chardev: reduce chardev ifdef mess a bit, Gerd Hoffmann, 2013/01/10
- [Qemu-devel] [PATCH v2 04/10] chardev: add qmp hotplug commands, with null chardev support, Gerd Hoffmann, 2013/01/10
- [Qemu-devel] [PATCH v2 10/10] chardev: add pty chardev support to chardev-add (qmp), Gerd Hoffmann, 2013/01/10
- Re: [Qemu-devel] [PATCH v2 10/10] chardev: add pty chardev support to chardev-add (qmp),
Eric Blake <=